review-test-quality

# Find recent solution docs with prevention strategies
find docs/solutions -name "*.md" -mtime -7 2>/dev/null

# Detect language and test framework
ls package.json pyproject.toml Cargo.toml go.mod Package.swift Gemfile 2>/dev/null

## Prevention Strategies
- Validate input is non-empty before processing
- Add timeout to external API calls
- Check array bounds before access

def test_empty_input_raises_validation_error():
    """Regression: docs/solutions/logic-errors/empty-array.md"""
    with pytest.raises(ValidationError):
        process_data([])

def test_handles_empty_input_gracefully():
    result = process_data([])
    assert result == []

describe('processData', () => {
  it('throws on empty input', () => {
    // Regression: docs/solutions/logic-errors/empty-array.md
    expect(() => processData([])).toThrow(ValidationError);
  });

  it('handles empty input gracefully', () => {
    expect(processData([])).toEqual([]);
  });
});

func TestProcessData_EmptyInput(t *testing.T) {
    // Regression: docs/solutions/logic-errors/empty-array.md
    _, err := ProcessData([]string{})
    if err == nil {
        t.Fatal("expected error for empty input")
    }
}

func TestProcessData_HandlesEmptyGracefully(t *testing.T) {
    result, err := ProcessData([]string{})
    require.NoError(t, err)
    assert.Empty(t, result)
}

#[test]
fn test_empty_input_returns_error() {
    // Regression: docs/solutions/logic-errors/empty-array.md
    let result = process_data(&[]);
    assert!(result.is_err());
}

#[test]
fn test_handles_empty_gracefully() {
    let result = process_data(&[]).unwrap_or_default();
    assert!(result.is_empty());
}

func testEmptyInputThrows() throws {
    // Regression: docs/solutions/logic-errors/empty-array.md
    XCTAssertThrowsError(try processData([])) { error in
        XCTAssertEqual(error as? ValidationError, .emptyInput)
    }
}

func testHandlesEmptyGracefully() {
    let result = processData([])
    XCTAssertEqual(result, [])
}

## Test Cases for Prevention Strategies

### Source
[Reference to solution doc, PR, or conversation context]

### Tests to Add

#### File: `tests/[appropriate_location]_test.[ext]`

```[language]
[Full test code matching project conventions]

[Command to run these specific tests]

## Quality Indicators

**Strong regression test:**
- Fails when the bug is reintroduced (verified by temporarily reverting fix)
- Documents the original failure in comments/docstring
- Tests the exact code path that failed
- Uses realistic input that triggered the bug

**Weak test (avoid):**
- Only tests happy path
- Uses trivial mock data
- Vague assertions (`assert result is not None`)
- No connection to actual failure mode

## Integration with workflows-compound

When invoked after `/workflows-compound`:

1. Read the solution doc just created
2. Extract items under "Prevention Strategies"
3. Identify the affected code paths
4. Generate tests matching project's test conventions
5. Place tests in appropriate test directory
6. Verify tests pass

## Guidelines

- **Match project conventions**: Use existing test framework, naming, and structure
- **Prefer specific over generic**: Test the exact failure mode
- **Include context**: Link tests back to the original issue
- **Consider CI**: Tests should run reliably in CI environment
- **Avoid flakiness**: No time-dependent or order-dependent tests