review-code

Ultrathink to exhaustively list ALL potential edge cases, then dispatch parallel epost-reviewer agents to verify: $ARGUMENTS

IMPORTANT: Activate needed skills. Ensure token efficiency. Sacrifice grammar for concision.

Workflow

1. Ultrathink Edge Cases

Main agent deeply analyzes the scope to LIST all potential edge cases FIRST:

• Read codebase-summary.md for context
• Use /scout to find relevant files
• Think exhaustively about what could go wrong:
  • Null/undefined scenarios
  • Boundary conditions (off-by-one, empty, max values)
  • Error handling gaps
  • Race conditions, async edge cases
  • Input validation holes
  • Security vulnerabilities
  • Resource leaks
  • Untested code paths

Output format:

## Edge Cases Identified

### Category: [scope-area]
1. [edge case description] → files: [file1, file2]
2. [edge case description] → files: [file3]

### Category: [another-area]
1. [edge case description] → files: [file4, file5]

1.5. Spec Compliance Check

Before quality review, verify the implementation matches requirements:

• Do NOT trust the implementer's self-report. Read actual code.
• Compare implementation line-by-line against plan/requirements/spec
• For each requirement, find the corresponding code and verify behavior

Spec reviewer outputs:

• ✅ Matches spec — requirement fulfilled at file:line
• ❌ Deviates — expected [X], found [Y] at file:line

If ANY ❌ deviations found:

• List all deviations with file:line references
• Fix deviations BEFORE proceeding to quality review (step 2+)
• Re-run spec check after fixes until all items are ✅

Only proceed to categorization and quality review after spec compliance passes.

2. Categorize & Assign

Group edge cases by similar scope for parallel verification:

• Each category → one epost-reviewer agent
• Max 6 categories (merge small ones)
• Each reviewer gets specific edge cases to VERIFY, not discover

3. Parallel Verification

Launch N epost-reviewer subagents simultaneously:

• Pass: category name, list of edge cases, relevant files
• Task: VERIFY if each edge case is properly handled in code
• Report: which edge cases are handled vs unhandled

Reviewer instruction:

Verify these specific edge cases in the given files:
[list of edge cases]

For each, report:
- Handled: [how it's handled]
- Unhandled: [what's missing]
- Partial: [what needs improvement]

4. Aggregate Results

Collect all verification reports:

## Edge Case Verification Report

### Summary
- Total edge cases: X
- Handled: Y
- Unhandled: Z
- Partial: W

### Unhandled Edge Cases (Need Fix)
| # | Edge Case | File | Status |
|---|-----------|------|--------|
| 1 | ...       | ...  | ...    |

### Partial Handling (Need Review)
| # | Edge Case | File | Issue |
|---|-----------|------|-------|
| 1 | ...       | ...  | ...   |

5. Auto-Fix Pipeline

IF unhandled/partial edge cases found:

• Ask: "Found N unhandled edge cases. Fix? [Y/n]"
• IF yes: Dispatch epost-debugger with unhandled list

6. Re-Review (1 pass only)

After debugger fixes, run a single verification pass — do NOT re-run full discovery:

• Re-dispatch one epost-reviewer agent with the original unhandled edge cases + fixed files
• Task: confirm each was resolved (handled / still unhandled / introduced regression)

IF re-review passes (all previously unhandled edge cases now handled):

• Proceed to Final Report → offer commit

IF re-review fails (still unhandled or regression):

• Report remaining issues clearly
• Stop — do NOT enter a third loop. Let the user decide next steps.

7. Final Report

• Summary of verification
• Ask: "Commit? [Y/n]" → use epost-git-manager

Example

User: /review-code auth module

1. Ultrathink → Lists 12 edge cases for auth:
   - Empty password submission
   - Token expiry during request
   - Concurrent login attempts
   - Invalid refresh token
   ...

2. Categorize → 3 groups:
   - Login flow (4 cases)
   - Token handling (5 cases)
   - Session management (3 cases)

3. Parallel → 3 epost-reviewers verify simultaneously

4. Aggregate → 8 handled, 3 unhandled, 1 partial

5. Fix → User approves → fix pipeline

6. Final → Commit changes