Agent skill

review

Code quality check with adaptive effort scaling. Includes security scanning.

Stars 163
Forks 31

Install this agent skill to your Project

npx add-skill https://github.com/majiayu000/claude-skill-registry/tree/main/skills/other/other/review-djnsty23-claude-auto-dev

SKILL.md

Review

Quality check on current/recent changes. Scales effort to the task.

Depth Levels

Command What It Does When to Use
review Adaptive effort based on change type (default) Before committing
review quick Build + typecheck only Typos, one-liners, low-risk changes
review deep Full 7-step verification + UI check After implementing features, before shipping

Effort Scaling (Default Mode)

Task Type Review Depth
Typo, one-liner Does it work? Ship it.
Feature, component Build + types + looks right
Architecture, refactor All above + system impact

More review for: money, security, user data, unfamiliar code. Less review for: isolated changes, low risk, well-understood code.

Quick Mode

After any change:

  1. npm run typecheck && npm run build — must pass
  2. Does it solve the problem?
  3. Would you approve this PR?

If yes to all, move on.

Default Mode (4 steps)

1. Check what changed

bash
git diff --name-only HEAD~3
git diff --staged --name-only

2. Run quality checks

bash
npm run typecheck
npm run build
npm run lint  # If available

3. Scan changed files for issues

For each changed file, check:

  • any types or @ts-ignore
  • console.log statements
  • Hardcoded colors (text-white, bg-gray-*)
  • Missing error handling
  • TODO/FIXME comments

4. Report

Review: [X files changed]
==========================

Build: Pass/Fail
Types: Pass/Fail
Lint: Pass/Fail (or N/A)

Issues Found:
- src/component.tsx:45 - console.log left in
- src/hook.ts:12 - Missing error handling

Suggestions:
- Consider extracting duplicate logic in X and Y

Overall: Ready to commit / Needs fixes

Deep Mode (7-step verification)

Confirm the work is done well, not just done. A task is complete when it works, solves the actual problem, and is production-ready.

What "Complete" Means

  1. It works — build passes, types check, feature functions.
  2. It solves the actual problem — not just the literal requirements.
  3. It's production-ready — handles errors, edge cases, real-world conditions.

Go beyond acceptance criteria when you see opportunities to improve UX, performance, or error messages.

For UI Tasks

Verify visually:

  • Does it look right at desktop and mobile (375px)?
  • Do all states work? (loading, error, empty, content)
  • Is sidebar hidden on mobile with a toggle?
  • Do grids stack to single column on mobile?
  • No horizontal overflow or clipped content?

Use agent-browser for verification when helpful:

bash
for port in 3000 3001 5173 8080; do
  curl -s http://localhost:$port > /dev/null && break
done
agent-browser open http://localhost:$port/path
agent-browser snapshot -i

7-Step Checklist

Run each check in order. Stop and fix on any failure.

1. Build Check

bash
npm run build 2>&1 | tail -20

Zero errors required. Note warnings.

2. Type Safety

bash
npm run typecheck 2>/dev/null || npx tsc --noEmit 2>/dev/null

Zero type errors required.

3. Test Suite

bash
npm test -- --passWithNoTests --watchAll=false 2>/dev/null

All tests pass. Report: X passed, Y failed, Z skipped.

4. Code Hygiene Scan

bash
grep -rn "console\.log\|console\.warn\|debugger\|TODO\|FIXME\|HACK" src/ --include="*.ts" --include="*.tsx" | grep -v node_modules | grep -v "\.test\." | head -20

Report count and locations. console.error is acceptable.

5. UI Quality Scan

bash
grep -rn "text-white\|text-black\|bg-white\|bg-black\|text-gray-\|bg-gray-" src/ --include="*.tsx" | grep -v node_modules | head -20
grep -rn "<img\|<Image" src/ --include="*.tsx" | grep -v "width\|height\|fill" | head -10

6. Diff Review

bash
git diff --stat
git diff --name-only

Only expected files modified. Flag unexpected changes.

7. Verdict

## Verification Result

| Check | Status | Notes |
|-------|--------|-------|
| Build | PASS/FAIL | |
| Types | PASS/FAIL | X errors |
| Tests | PASS/FAIL | X passed, Y failed |
| Hygiene | PASS/WARN | X debug statements |
| UI Quality | PASS/WARN | X hardcoded colors |
| Diff | PASS/WARN | X files modified |

**Overall: PASS / FAIL**

If PASS: "Ready for commit." If FAIL: list specific items to fix.

Quality Framework Reference

Apply principles from related skills when reviewing:

Skill Check For
standards Type safety, design tokens, all UI states, React patterns
design Avoid AI slop (no purple gradients, no Inter/Roboto)
security Secrets, RLS, input validation, XSS

The Standard

Would a senior developer approve this PR? If not, improve it.

Expand your agent's capabilities with these related and highly-rated skills.

Didn't find tool you were looking for?

Be as detailed as possible for better results