Quality Review Skill

=== PURPOSE ===

This skill provides procedures for conducting quality code reviews. QA Lead has BLOCKING authority for quality issues.

=== USED BY ===

=== PROCEDURE: Quality Review Checklist ===

Template: @ref(CB-TPL-QUALREVIEW-001)

Test Coverage

• Unit tests cover new functionality
• Integration tests where appropriate
• Edge cases tested
• Error scenarios tested
• Coverage meets threshold (e.g., 80%)

Code Quality

• No code smells
• Single responsibility principle followed
• DRY principle applied
• Clear naming conventions
• Appropriate comments where needed

Maintainability

• Code is readable
• Complex logic documented
• No magic numbers/strings
• Consistent patterns used

Performance

• No obvious performance issues
• N+1 queries avoided
• Appropriate caching considered
• Memory leaks avoided

Error Handling

• Errors handled gracefully
• User-friendly error messages
• Appropriate logging

=== PROCEDURE: Coverage Assessment ===

Steps:

1. Review coverage report
2. Identify uncovered lines
3. Assess if uncovered code needs tests
4. Document coverage gaps
5. Approve or request additional tests

Minimum Thresholds:

• Line coverage: 80%
• Branch coverage: 75%
• Function coverage: 80%

=== PROCEDURE: Code Smell Detection ===

Common Code Smells:

• Long methods (>20 lines)
• Large classes (>300 lines)
• Duplicate code
• Deep nesting (>3 levels)
• Too many parameters (>4)
• Comments explaining bad code

=== PROCEDURE: Quality Finding Documentation ===

Format:

### [PRIORITY] Finding Title

**Location:** file.js:line
**Type:** [Coverage/Quality/Performance/etc.]
**Priority:** [High/Medium/Low]

**Issue:**
What the quality issue is.

**Recommendation:**
How to improve it.

=== PRIORITY DEFINITIONS ===

=== ANTI-PATTERNS ===

Nitpicking

Problem: Blocking for style preferences Solution: Focus on substantive issues

Ignoring Tests

Problem: Not reviewing test quality Solution: Review tests as carefully as code

=== RELATED SKILLS ===