# Get PR details
gh pr view 123

# Get file changes
gh pr diff 123

# Get commits
gh pr view 123 --json commits

# Check status
gh pr checks 123

# PR Analysis Report

## Summary
- **PR #:** 123
- **Title:** Add user authentication feature
- **Author:** @username
- **Type:** Feature
- **Size:** Medium (250 lines changed across 8 files)

## Overview
[Brief description of what the PR does]

## Quality Assessment

### ✅ Strengths
- Well-tested with 95% coverage
- Clear code structure
- Good error handling
- Documentation included

### ⚠️ Concerns
- Missing input validation in auth middleware
- No rate limiting implemented
- Database migration needs review

### 🔴 Issues
- Security: Password stored in plain text
- Performance: N+1 query in user lookup

## Detailed Analysis

### Code Quality: 7/10
- Clean implementation overall
- Some functions could be extracted
- Good naming conventions

### Test Coverage: 9/10
- Comprehensive unit tests
- Integration tests included
- Missing edge case tests for token expiration

### Documentation: 6/10
- API endpoints documented
- Missing setup instructions
- No migration guide

### Security: 5/10
- ⚠️ Critical: Password storage issue
- Missing input sanitization
- No rate limiting

## Recommendations

### Must Fix Before Merge
1. Hash passwords before storing
2. Add input validation to auth middleware
3. Fix N+1 query performance issue

### Should Fix
1. Implement rate limiting
2. Add token expiration tests
3. Update setup documentation

### Nice to Have
1. Extract validation logic to separate module
2. Add more descriptive error messages
3. Improve logging

## Files Requiring Attention

### Critical Review Needed
- `src/auth/middleware.js` - Security concerns
- `src/models/user.js` - Password storage issue

### Minor Issues
- `src/routes/auth.js` - Could improve error handling
- `tests/auth.test.js` - Add edge case tests

## Checklist

- [x] Code review completed
- [x] Tests are passing
- [ ] Security review needed
- [x] Documentation updated
- [ ] Breaking changes documented
- [x] Performance acceptable

## Merge Recommendation

**Status:** ⚠️ **NOT READY**

**Reason:** Critical security issues must be addressed (password storage).

**Next Steps:**
1. Fix password hashing
2. Add input validation
3. Request security review
4. Re-run analysis after fixes

# Check all required checks
gh pr checks 123

# Look for:
- Tests passing ✅
- Linting passing ✅
- Build successful ✅
- Security scan clean ✅
- Coverage requirements met ✅

# Check for conflicts
gh pr view 123 --json mergeable

# If conflicts exist, request rebase

# Check approval status
gh pr view 123 --json reviewDecision

# Ensure required approvals obtained

// ❌ Debug code left in
console.log('debug:', data);

// ❌ Commented code
// const oldFunction = () => {...}

// ❌ Hardcoded values
const apiKey = "abc123";

// ❌ Poor error handling
try { doSomething(); } catch {}

// ❌ No validation
function updateUser(id, data) {
  return db.users.update(id, data); // No validation!
}

// ❌ Test doesn't actually test anything
it('should work', () => {
  doSomething();
  // No assertions!
});

// ❌ Test depends on external state
it('updates user', () => {
  updateUser(globalUserId); // Depends on global
});

// ❌ Flaky test
it('should complete within 100ms', () => {
  // Time-based tests are flaky
});

**Issue:** [Description]
**Why it matters:** [Impact]
**Suggestion:**
```code
[Improved code]

### For Questions

### For Praise

## Merge Decision Matrix

### ✅ Ready to Merge

**Criteria:**
- All tests passing
- Required approvals obtained
- No security issues
- Documentation complete
- No breaking changes (or properly handled)
- Code quality acceptable
- Performance acceptable

### ⏸️ Needs Work

**Common reasons:**
- Minor issues to fix
- Missing documentation
- Needs more tests
- Small refactoring needed

### 🛑 Not Ready

**Blocking issues:**
- Critical bugs
- Security vulnerabilities
- Failing tests
- Breaking changes not documented
- Major architectural concerns
- Performance problems

## Best Practices

### ✅ Good PR Practices

- **Focused scope:** One logical change
- **Small size:** Easy to review
- **Clear description:** Explains what and why
- **Tests included:** Proves it works
- **Documentation updated:** Keeps docs current
- **Clean commits:** Logical, well-named
- **Self-reviewed:** Author checked their own work

### ❌ PR Anti-Patterns

- **Kitchen sink:** Too many unrelated changes
- **Massive size:** 1000+ lines
- **"Fix it later":** Known issues deferred
- **No tests:** "Will add tests later"
- **Drive-by changes:** Unrelated refactoring
- **Debug commits:** Console.logs, temp files

## Analysis Workflow

1. **Gather information** - PR details, diffs, checks
2. **Quick scan** - Overall scope and size
3. **Deep review** - Code quality, tests, docs
4. **Security check** - Vulnerabilities, risks
5. **Performance check** - Potential bottlenecks
6. **Generate report** - Structured analysis
7. **Provide recommendation** - Ready/Not ready
8. **Suggest next steps** - What needs to be done

## Tools Usage

- **Bash:** Run gh commands, git operations
- **Read:** Examine changed files
- **Grep:** Search for patterns, issues
- **Glob:** Find related files

## Example Analysis

## Remember

- **Be thorough but efficient**
- **Focus on high-impact issues**
- **Be constructive, not critical**
- **Explain the "why" behind feedback**
- **Recognize good work**
- **Balance perfection with pragmatism**

Good PR analysis catches bugs before they reach production and helps improve code quality across the team.