Task tool (superpowers:code-reviewer):
  Use template at requesting-code-review/code-reviewer.md

  WHAT_WAS_IMPLEMENTED: [from implementer's report]
  PLAN_OR_REQUIREMENTS: Task N from [plan-file]
  BASE_SHA: [commit before task]
  HEAD_SHA: [current commit]
  DESCRIPTION: [task summary]

  ADDITIONAL_REVIEW_CRITERIA: |
    ## .NET Test Quality Review Checklist

    Review ALL test files in the diff. For each test, apply these checks:

    ### Behavioral Testing
    - [ ] No getter/setter tests (flag: `CanSetProperties`, `CanSetName`, `HasInitializedCollections`, `IsNullable`, `HasEmptyDefault`)
    - [ ] Every test catches a real bug — ask "what bug does this prevent?" If answer is "none", flag it
    - [ ] Tests verify outcomes (returned data, DB state, domain state), not mock interactions (`Received()`, `Verify()`)
    - [ ] No assertion-less tests (every test has at least one Assert)
    - [ ] Integration tests assert response body or DB state, not just HTTP status code

    ### Test Structure
    - [ ] Max 3 assertions per test (single logical assertion OK even if multiple Assert calls)
    - [ ] Naming follows `MethodName_Scenario_ExpectedBehavior`
    - [ ] `[Theory]`+`[InlineData]` used when testing same behavior with multiple inputs
    - [ ] No "and" in test names (split into separate tests)

    ### Test Infrastructure
    - [ ] Shared `CustomWebApplicationFactory` used for integration tests (not inline `WebApplicationFactory<Program>`)
    - [ ] `IClassFixture<CustomWebApplicationFactory>` pattern (not new factory per test)
    - [ ] Setup helpers in shared `TestHelpers` class (not duplicated across test files)
    - [ ] No test-only methods added to production classes
    - [ ] SQLite in-memory with kept-alive connection (NOT EF InMemory provider)

    ### Mock Boundaries
    - [ ] Infrastructure mocked: DbContext, IHttpClientFactory, ILogger, TimeProvider, external APIs
    - [ ] Domain NOT mocked: entities, value objects, pure functions use real instances
    - [ ] NSubstitute used (not Moq, not FakeItEasy) — project convention, adjust if your project differs
    - [ ] Mock setup is <50% of test code

    ### EF Core Patterns
    - [ ] No N+1 queries — eager load with `.Include()` or use projections (`.Select()`) instead of lazy-loading in loops
    - [ ] Read-only queries use `.AsNoTracking()` to avoid unnecessary change tracking overhead
    - [ ] DbContext lifetime is scoped (not singleton/transient) — verify DI registration
    - [ ] Migrations are clean — no empty migrations, no manual SQL unless justified, migration order matches commit history
    - [ ] No business logic in migrations — data transforms belong in domain services or one-time scripts
    - [ ] Queries use server-side evaluation — flag `.ToList()` before `.Where()` or LINQ that forces client evaluation

    ### Coverage
    - [ ] Edge cases tested (null, empty, boundary values)
    - [ ] Error paths tested (invalid input, not found, unauthorized)
    - [ ] All new public methods have at least one test
    - [ ] Happy path + at least one failure path per endpoint

    ### Anti-Patterns to Flag
    Flag these by name in review:
    - **CanSetProperties**: Test that only verifies property assignment
    - **IsNullable**: Test that only checks default null values
    - **HasEmptyDefault**: Test that only checks empty collection initialization
    - **MockVerifyOnly**: Test where only assertion is `Received()` or `Verify()`
    - **DuplicateFactory**: `new WebApplicationFactory<Program>()` instead of shared fixture
    - **AssertionOverload**: Test with >3 assertions testing unrelated things (Important); >5 unrelated assertions is Critical
    - **DomainMock**: `Substitute.For<DomainEntity>()` on domain objects
    - **Assertionless**: Test with zero assertions — passes silently, catches nothing
    - **StatusCodeOnly**: Integration test that only checks `EnsureSuccessStatusCode()` or status code without verifying body/DB

    ### Severity Guide
    - **Critical**: getter/setter tests, domain mocking, no tests for new methods, >5 unrelated assertions, assertion-less tests
    - **Important**: missing Theory, >3 unrelated assertions, duplicate factory, mock-verify-only, status-code-only integration tests
    - **Minor**: naming convention, missing edge case test