Agent skill

app-intents-code-review

Reviews App Intents code for intent structure, entities, shortcuts, and parameters. Use when reviewing code with import AppIntents, @AppIntent, AppEntity, AppShortcutsProvider, or @Parameter.

View SKILL.md on GitHub Repository
Stars 44
Forks 5

Install this agent skill to your Project

npx add-skill https://github.com/existential-birds/beagle/tree/main/plugins/beagle-ios/skills/app-intents-code-review

SKILL.md

App Intents Code Review

Quick Reference

Issue Type Reference
AppIntent protocol, perform(), return types references/intent-structure.md
AppEntity, EntityQuery, identifiers references/entities.md
AppShortcutsProvider, phrases, discovery references/shortcuts.md
@Parameter, validation, dynamic options references/parameters.md

Review Checklist

  • perform() marked with @MainActor if accessing UI/main thread resources
  • perform() completes within 30-second timeout (no heavy downloads/processing)
  • Custom errors conform to CustomLocalizedStringResourceConvertible
  • EntityQuery.entities(for:) handles missing identifiers gracefully
  • EntityStringQuery used if Siri voice input needed (not plain EntityQuery)
  • suggestedEntities() returns reasonable defaults for disambiguation
  • AppShortcut phrases include .applicationName parameter
  • Non-optional @Parameter has sensible defaults or uses requestValue()
  • @IntentParameterDependency not used on iOS 16 targets (crashes)
  • Phrases localized in AppShortcuts.strings, not Localizable.strings
  • App Intents defined in app bundle, not Swift Package (pre-iOS 17)
  • isDiscoverable = false for internal/widget-only intents

When to Load References

  • AppIntent protocol implementation -> intent-structure.md
  • Entity queries, identifiers, Spotlight -> entities.md
  • App Shortcuts, phrases, discovery -> shortcuts.md
  • Parameter validation, dynamic options -> parameters.md

Review Questions

  1. Does perform() handle timeout limits for long-running operations?
  2. Are entity queries self-contained (no @Dependency injection in Siri context)?
  3. Do phrases read naturally and include the app name?
  4. Are SwiftData models passed by persistentModelID, not directly?
  5. Would migrating from SiriKit break existing user shortcuts?

Recommended Agent Skills

Expand your agent's capabilities with these related and highly-rated skills.

existential-birds/beagle

review-python

Comprehensive Python/FastAPI backend code review with optional parallel agents

44 5
Explore
existential-birds/beagle

review-verification-protocol

Mandatory verification steps for all code reviews to reduce false positives. Load this skill before reporting ANY code review findings.

44 5
Explore
existential-birds/beagle

sqlalchemy-code-review

Reviews SQLAlchemy code for session management, relationships, N+1 queries, and migration patterns. Use when reviewing SQLAlchemy 2.0 code, checking session lifecycle, relationship() usage, or Alembic migrations.

44 5
Explore
existential-birds/beagle

fastapi-code-review

Reviews FastAPI code for routing patterns, dependency injection, validation, and async handlers. Use when reviewing FastAPI apps, checking APIRouter setup, Depends() usage, or response models.

44 5
Explore
existential-birds/beagle

pytest-code-review

Reviews pytest test code for async patterns, fixtures, parametrize, and mocking. Use when reviewing test_*.py files, checking async test functions, fixture usage, or mock patterns.

44 5
Explore
existential-birds/beagle

postgres-code-review

Reviews PostgreSQL code for indexing strategies, JSONB operations, connection pooling, and transaction safety. Use when reviewing SQL queries, database schemas, JSONB usage, or connection management.

44 5
Explore

Didn't find tool you were looking for?

Be as detailed as possible for better results